[Release] Steam Resolver - Printable Version

[Release] Steam Resolver - Printable Version

+- Sinisterly (https://sinister.ly)
+-- Forum: Coding (https://sinister.ly/Forum-Coding)
+--- Forum: Visual Basic & .NET Framework (https://sinister.ly/Forum-Visual-Basic-NET-Framework)
+--- Thread: [Release] Steam Resolver (/Thread-Release-Steam-Resolver)

Pages: 1 2

[Release] Steam Resolver - SQLi - 03-12-2013

Tags: Steam Resolver, Grab IP from Steam, Valve, Half-Life 3, URL-to-IP, Steam ID, Steam profile URL, Download

RE: [Release] Steam Resolver (with a GUI) - ねこまっしぐら - 03-12-2013

Cool, thanks for the share.

RE: [Release] Steam Resolver (with a GUI) - cxS - 03-12-2013

I don't agree with a lot of things in the reflected code that I can see, but at least you're trying to contribute...

RE: [Release] Steam Resolver (with a GUI) - SQLi - 03-12-2013

(03-12-2013, 06:10 AM)cxS Wrote: I don't agree with a lot of things in the reflected code that I can see, but at least you're trying to contribute...

You probably mean the URL to ID, I just threw something together real quick for that. I'm planning on changing it later. Right now it's just a messy temporary solution.

And what do you mean by trying to contribute? Even though the code is a bit messy it still works, I'm contributing.

RE: [Release] Steam Resolver (with a GUI) - cxS - 03-12-2013

(03-12-2013, 07:45 AM)SQLi Wrote:
(03-12-2013, 06:10 AM)cxS Wrote: I don't agree with a lot of things in the reflected code that I can see, but at least you're trying to contribute...

You probably mean the URL to ID, I just threw something together real quick for that. I'm planning on changing it later. Right now it's just a messy temporary solution.

And what do you mean by trying to contribute? Even though the code is a bit messy it still works, I'm contributing.

I'm implying trying to contribute good resources. Although by contributing, you had to first "try" to do, so I don't see any reason for why my statement should be confusing.

I mean a few other things though. But since the source is not released here, I don't really care to provide too much feedback.

RE: [Release] Steam Resolver (with a GUI) - SQLi - 03-12-2013

(03-12-2013, 07:54 AM)cxS Wrote:
(03-12-2013, 07:45 AM)SQLi Wrote:
(03-12-2013, 06:10 AM)cxS Wrote: I don't agree with a lot of things in the reflected code that I can see, but at least you're trying to contribute...

You probably mean the URL to ID, I just threw something together real quick for that. I'm planning on changing it later. Right now it's just a messy temporary solution.

And what do you mean by trying to contribute? Even though the code is a bit messy it still works, I'm contributing.

I'm implying trying to contribute good resources. Although by contributing, you had to first "try" to do, so I don't see any reason for why my statement should be confusing.

I mean a few other things though. But since the source is not released here, I don't really care to provide too much feedback.

EDIT: Which "few other" things?

RE: [Release] Steam Resolver (with a GUI) - cxS - 03-12-2013

1. Not disposing of your WebClient() which you instantiate a new instance of on the heap every call:

Code:
Public Function Steam(ByVal SteamID As String) As String
	Dim hay As String = New WebClient().DownloadString(("http://tf2-trader.com/bans/index.php?p=banlist&searchText=" & SteamID.Replace(":", "%3A") & "&Submit="))
	Return Me.GetExternalIp(hay)
End Function

Same thing with Steam2(). Although this could become an overloaded method instead of what you're doing there.

2. This couldn't be any more poor, in terms of a validation check...

Code:
Private Sub PictureBox6_Click(ByVal sender As Object, ByVal e As EventArgs)
	Try 
		Dim ping As New Ping
		If (ping.Send(Me.TextBox3.Text).RoundtripTime > 1) Then
			Me.TextBox3.Text = "IP is alive."
		End If
	Catch exception1 As Exception
		Dim exception As Exception = exception1
		Me.TextBox3.Text = "IP is dead."
	End Try
End Sub

If you're going to use the Ping class, you should be using the IPStatus return value instead. This is ALSO a class that implements the IDisposable interface, and you're not calling it's Dispose() method here.

3. You've much overused the Try Catch as a method of error handling which is not good at all. That's lazy error handling and bad coding standards.

RE: [Release] Steam Resolver - sajjad73 - 11-20-2015

Cool, thanks for the share.

RE: [Release] Steam Resolver - pokeemerald - 12-26-2015

Thanks! :3 Will definietely use it ^^

RE: [Release] Steam Resolver - Xfcbantox - 02-07-2016

Thanks you man ! I love you my BB