(03-23-2014, 01:45 AM)0xDEAD10CC Wrote: That sounds like a make belief story to me, no that's not it. Post your code in code tags please.

---

Code:

@echo off& setlocal enabledelayedexpansion set outfile=Z:\batch.txt :: save to file set name=Bob echo %name%> %outfile% call :get_name :: resave the name to file echo %name%> %outfile% call :get_name :: dummy if statement (just for proof) set name=Billy if 1==1 echo %name%> %outfile% call :get_name goto :eof :: grab name from file and show value :get_name set /p name=<%outfile% echo Variable created from file: %name% goto :eof

No spaces...

Code:

Variable created from file: Bob Variable created from file: Bob Variable created from file: Billy

(03-23-2014, 05:23 AM)0xDEAD10CC Wrote: I'd suggest creating some functions though.

(03-23-2014, 05:32 AM)0xDEAD10CC Wrote: You could also have files...

Code:

@echo off&setlocal enabledelayedexpansion call get_username.bat

In get_username.bat, you could have everything that would grab the user input. Then you can use it later.

Example:
main.bat:

Code:

@echo off&setlocal enabledelayedexpansion call functions1.bat echo %user%

functions1.bat:

Code:

set user=Bob

Output:

Code:

Bob

---

For a simple function:

Code:

@echo off&setlocal enabledelayedexpansion call :get_username echo %user% pause&goto :eof :get_username set /p user=Enter a username: goto :eof

---

The other way you could set it up is have a file that just holds related functions, and call functions from within the file externally.

(03-23-2014, 05:51 AM)DarkMuse Wrote: But why do all that extra work? What good would it do for the program specifically?

(03-23-2014, 06:08 AM)0xDEAD10CC Wrote: Why do people use classes, structs, and other datatypes along with functions in other languages, and separate concerns within separate files in ANY program? Think...

This is a lot easier to manage:

Code:

@echo off&setlocal enabledelayedexpansion call functions1.bat :func1 arg1 arg2

Code:

call %*&goto :eof :func1 echo Hi you called func1 with args: %1 %2 goto :eof :func2 echo Hi you called func2 with args: %1 %2 goto :eof :func3 echo Hi you called func3 with args: %1 %2 goto :eof

---

Look at a case where this may be useful:

main.bat

Code:

@echo off&setlocal enabledelayedexpansion call functions1.bat :func1 arg1 arg2 echo.&echo.Testing with DEBUG mode on...&echo. set DEBUG=1 call myfunctions.bat :func1 arg1 arg2

myfunctions.bat

Code:

setlocal enabledelayedexpansion if defined DEBUG ( set args=%*&if defined args set "args=!args:%1 =!" echo.CALL ^> %1 echo.ARGS ^> !args! echo. ) call %*&goto :eof ::------------------------------- :: FUNCTIONS ::------------------------------- :func1 echo Hi you called func1 with args: %1 %2 goto :eof :func2 echo Hi you called func2 with args: %1 %2 goto :eof :func3 echo Hi you called func3 with args: %1 %2 goto :eof

OUTPUT:

Code:

Hi you called func1 with args: arg1 arg2 Testing with DEBUG mode on... CALL > :func1 ARGS > arg1 arg2 Hi you called func1 with args: arg1 arg2

You don't see anything useful with this?..