(07-29-2013, 09:58 AM)Psycho_Coder Wrote: Hi @Solixious,

The game looks good and I played and it works good. But I have some comments.

In SpaceWarrior.java

Here the modifiers are missing. You can use private.

Code:

ArrayList<Boulder> boulders; ArrayList<Shine> shines;

Quote:Java initializes int variables with 0 so no need of initializing them with 0 again. However there isn't a problem if you do so.

Code:

private int ctr=0,score=0,highScore=0;

Quote:Now in your constructor SpaceWarrior you have initialized the variables but I would prefer using the this keyword. I think it must be used. Also you have created the basic frame of the game inside it. I would prefer creating a separate method and initializing it there and then calling that method from the constructor. Doing it this way increases readability.

Here is what I was expecting :-

Code:

public SpaceWarrior() { this.highScore=5000; this.gameOver=false; this.boulders=new ArrayList<Boulder>(); this.shines=new ArrayList<Shine>(); sc=new SpaceCraft(); this.spaceCraft=sc.getImage(); this.missile=new Missile(sc).getImage(); initializeframe(); this.timer=new Timer(10,this); timer.start(); } private void initializeframe(){ fr=new JFrame("Space Warrior"); fr.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); addKeyListener(new TAdapter()); fr.add(this); fr.setSize(500,500); fr.setResizable(false); fr.setLocationRelativeTo(null); fr.setVisible(true); setFocusable(true); setDoubleBuffered(true); }

Quote:@Override notation must be added to the following :- paint, update, actionPerformed, keyPressed, and keyReleased


In SpaceCraft.java

Same as mention earlier. Use a modifier for ArrayList<Missile> and fire method (Instead of public).

In the keyPressed method, why not use switch I think using switch would be a better option. Something like :-

Code:

public void keyPressed(KeyEvent e) { int key=e.getKeyCode(); switch(key){ case KeyEvent.VK_UP : dy=-2;break; case KeyEvent.VK_DOWN : dy=+2;break; case KeyEvent.VK_RIGHT : dx=+2;break; case KeyEvent.VK_LEFT : dx=-2;break; case KeyEvent.VK_SPACE : fire(); } }

Quote:Others :-

I see that you have used an option of health in your code. Then why not display your health. If the player sees that his health has decreased he will take more precautions and will play carefully. So you must display the health.

(07-29-2013, 10:29 AM)Psycho_Coder Wrote: @Solixious I made a mistake as well regarding that health sorry I overlooked it hehe.

(07-30-2013, 07:07 PM)Deque Wrote: Sweet game.
I suggest you read this article: http://www.java-gaming.org/index.php?topic=24220.0
It is about game loops and matches my observation that most people use the Timer class for a game loop. I think it can be sufficient for a little game like this. But maybe you want to do something bigger some day.
Game engines can also be a great help. I.e. Slick2d, JMonkey

(07-30-2013, 10:18 PM)noize Wrote: The game looks good, although, there's something I'd like to bring to your attention.

1. I just easily (and boredly) got 3962400 points. How? I merely blasted a few asteroids and then hid myself in the warm bottom left corner keeping my finger on the whitespace bar. I can't say how much I've spent like that, I was really hoping for something to hit me as soon as possible. You might maybe fix this by temporarily increasingly increasing the number of asteroids spawning in that row, just until the user presses the left/right key (check for the user to actually move (i.e. it's not valid if he's on the right side and presses the right key)). Don't get instantly back to the same number of asteroids as in the other rows, just start decreasing. So, to sum up, slowly increase the number of asteroids in the row the ship is (right from the moment when the user gets in a position) and start decreasing if he moves away.

2. If you do as above mentioned, people won't be able to get more than 20000-30000 points in any way at all. At that point asteroids start becoming too many and there is no way to survive.

Well done, really.