Eleven Years of Service
Posts: 588
Threads: 96
RE: Phisher Example | HF 05-07-2016, 09:16 PM
#2
Seems decent, got allot of places to improve. And yeah phishers aren't allowed on HF. However I would recommend a few things. First off is using GitHub not mediafire, this would be much better suited for it. Next is a few tips for fixing some bad coding practices:
-Stay away from Me.Dispose, use Environment.Exit in place of it.
-Multi-thread or you will form lock
-instead of using two If statements to check for a valid email address, just use the operator AND ex.(if i = 1 AND g = 3 then)
-use If Not instead of just checking if, then including an empty block with Else.
-Why use httpwebrequests when you could complete this in one line with New Webclient().DownloadString()?
-For the love of god stay away from spamming &&&&&&& every time you're building a big string, use String.Format()
-You have allot of empty Else blocks, they don't sure a purpose.
β’
Fourteen Years of Service
Posts: 18,858
Threads: 2,029
RE: Phisher Example | HF 05-07-2016, 09:52 PM
#3
Cleared a few posts. Let's remain friendly, please. If you have something negative to say, state it respectfully. Childishness (like name-calling) isn't welcome.
β’
Twelve Years of Service
Posts: 1,038
Threads: 59
RE: Phisher Example 05-08-2016, 12:39 AM
#5
Can we clearly highlight the fact that the PHP script has no rate limiting or length protections, at least? Can easily crash the server by spamming it with extremely long strings and filling up the disk. Only limit is the web server's maximum post length, but there's nothing exactly stopping it from repeating that request a few million times.
β’